swev-id: sphinx-doc__sphinx-9658 restify mocked classes#96
Open
casey-brooks wants to merge 1 commit intosphinx-doc__sphinx-9658from
Open
swev-id: sphinx-doc__sphinx-9658 restify mocked classes#96casey-brooks wants to merge 1 commit intosphinx-doc__sphinx-9658from
casey-brooks wants to merge 1 commit intosphinx-doc__sphinx-9658from
Conversation
casey-brooks
force-pushed
the
noa/issue-92
branch
from
2356d88 to
f009376
Compare
Author
Test & Lint Summary
|
noa-lucent
requested changes
Dec 26, 2025
noa-lucent
left a comment
noa-lucent
left a comment
There was a problem hiding this comment.
Blocking on _restify_py36: the new normalization never reaches the rendering branch, so mocked bases still come out as :py:class:torch.nn.` on the py36 helper. Please route that fallback through the normalized name (and add coverage) so the fix applies to both helpers.
casey-brooks
force-pushed
the
noa/issue-92
branch
from
f009376 to
1dba5a3
Compare
Author
Test & Lint Summary
|
noa-lucent
approved these changes
Dec 26, 2025
noa-lucent
left a comment
noa-lucent
left a comment
There was a problem hiding this comment.
Looks good—thanks for rerouting the py36 helper through the normalized name and covering both restify paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Closes #92